[REFACTOR][PY][API-CHANGE] establish tvm.ir, migrate corresponding files #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
changed the title
|
cc @zhiics @wweic @yzhliu @icemelon9 @jroesch @MarisaKirisame @ZihengJiang |
zhiics
reviewed
Feb 11, 2020
python/tvm/ir/adt.py
Outdated
| class Constructor(RelayExpr): | ||
| """Relay ADT constructor. | ||
|
|
||
|
|
python/tvm/ir/base.py
Outdated
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| """Span data structures.""" |
There was a problem hiding this comment.
The file description seems not quite accurate as there are more data structures
python/tvm/ir/base.py
Outdated
| if there is meta data. | ||
|
|
||
| annotate: Optional[Object->str] | ||
| Optional annotate function to provide additional |
There was a problem hiding this comment.
Optional is a type annotation in python3
There was a problem hiding this comment.
yeah, I was talking about "Optional annotate function to ..." where "Optional" should be an adverb.
There was a problem hiding this comment.
ah i see, thanks for the catch!
python/tvm/ir/type.py
Outdated
| class FuncType(Type): | ||
| """Function type. | ||
|
|
||
|
|
tqchen
changed the title
…lay files. This PR establishes tvm.ir and migrates the corresponding relay files into the new folder. API Change: - relay.Module -> tvm.IRModule
tqchen
changed the title
|
Updated the PR and comment, @zhiics please help to take another look |
zhiics
approved these changes
Feb 11, 2020
tqchen
force-pushed
the
pyir
branch
2 times, most recently
from
8779ee7
to
a1f3c5c
Compare
|
@MarisaKirisame The Base class has been moved to tvm.ir.RelayExpr to reflect the changes in the C++ side, so now ExprWithOp is just a temporary class to add the additional ops. RelayExpr is the real Expr class |
tqchen
changed the title
MarisaKirisame
approved these changes
Feb 12, 2020
|
Thanks @MarisaKirisame @zhiics |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
…les (apache#4862) * [REFACTOR][PY][API-CHANGE] establish tvm.ir, migrate corresponding relay files. This PR establishes tvm.ir and migrates the corresponding relay files into the new folder. API Change: - relay.Module -> tvm.IRModule * Update with ADT * Migrate transform * address comments * Migrate module * Migrate json_compact * Migrate attrs * Move LoweredFunc to stmt temporarily * temp migrate container * Finish migrate container
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
…les (apache#4862) * [REFACTOR][PY][API-CHANGE] establish tvm.ir, migrate corresponding relay files. This PR establishes tvm.ir and migrates the corresponding relay files into the new folder. API Change: - relay.Module -> tvm.IRModule * Update with ADT * Migrate transform * address comments * Migrate module * Migrate json_compact * Migrate attrs * Move LoweredFunc to stmt temporarily * temp migrate container * Finish migrate container
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
…les (apache#4862) * [REFACTOR][PY][API-CHANGE] establish tvm.ir, migrate corresponding relay files. This PR establishes tvm.ir and migrates the corresponding relay files into the new folder. API Change: - relay.Module -> tvm.IRModule * Update with ADT * Migrate transform * address comments * Migrate module * Migrate json_compact * Migrate attrs * Move LoweredFunc to stmt temporarily * temp migrate container * Finish migrate container
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Mar 29, 2020
…les (apache#4862) * [REFACTOR][PY][API-CHANGE] establish tvm.ir, migrate corresponding relay files. This PR establishes tvm.ir and migrates the corresponding relay files into the new folder. API Change: - relay.Module -> tvm.IRModule * Update with ADT * Migrate transform * address comments * Migrate module * Migrate json_compact * Migrate attrs * Move LoweredFunc to stmt temporarily * temp migrate container * Finish migrate container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR establishes tvm.ir and migrates the corresponding relay files into the new folder.
API Change: